r
/
bookshelf-doc
mirror of https://github.com/jrpotter/bookshelf-doc
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: don't fetch unused cache, FF fixes

main
Mario Carneiro 2023-09-20 21:37:52 -04:00 committed by Henrik Böving
parent cf072e2be0
commit 800041825e
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
static/declaration-data.js
View File

@ -54,7 +54,12 @@ export class DeclarationDataCenter {
); );
// try to use cache first // try to use cache first
const data = await fetchCachedDeclarationData().catch(_e => null); // TODO: This API is not thought 100% through. If we have a DB cached
// already it will not even ask the remote for a new one so we end up
// with outdated declaration-data. This has to have some form of cache
// invalidation: https://github.com/leanprover/doc-gen4/issues/133
// const data = await fetchCachedDeclarationData().catch(_e => null);
const data = null;
if (data) { if (data) {
// if data is defined, use the cached one. // if data is defined, use the cached one.
return new DeclarationDataCenter(data); return new DeclarationDataCenter(data);
@ -72,7 +77,7 @@ export class DeclarationDataCenter {
* Search for a declaration. * Search for a declaration.
* @returns {Array<any>} * @returns {Array<any>}
*/ */
search(pattern, strict = true, allowedKinds=undefined, maxResults=undefined) { search(pattern, strict = true, allowedKinds = undefined, maxResults = undefined) {
if (!pattern) { if (!pattern) {
return []; return [];
} }
@ -258,12 +263,7 @@ async function fetchCachedDeclarationData() {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
let transactionRequest = store.get(CACHE_DB_KEY); let transactionRequest = store.get(CACHE_DB_KEY);
transactionRequest.onsuccess = function (event) { transactionRequest.onsuccess = function (event) {
// TODO: This API is not thought 100% through. If we have a DB cached resolve(event.target.result);
// already it will not even ask the remote for a new one so we end up
// with outdated declaration-data. This has to have some form of cache
// invalidation: https://github.com/leanprover/doc-gen4/issues/133
//resolve(event.target.result);
resolve(undefined);
}; };
transactionRequest.onerror = function (event) { transactionRequest.onerror = function (event) {
reject(new Error(`fail to store declaration data`)); reject(new Error(`fail to store declaration data`));

2
static/find/find.js
View File

@ -49,7 +49,7 @@ const queryParams = new Map(
const fragmentPaths = fragment?.split(LEAN_FRIENDLY_SLASH_SEPARATOR) ?? []; const fragmentPaths = fragment?.split(LEAN_FRIENDLY_SLASH_SEPARATOR) ?? [];
const encodedPattern = queryParams.get("pattern") ?? fragmentPaths[1]; // if first fail then second, may be undefined const encodedPattern = queryParams.get("pattern") ?? fragmentPaths[1]; // if first fail then second, may be undefined
const pattern = decodeURIComponent(encodedPattern); const pattern = encodedPattern && decodeURIComponent(encodedPattern);
const strict = (queryParams.get("strict") ?? "true") === "true"; // default to true const strict = (queryParams.get("strict") ?? "true") === "true"; // default to true
const view = fragmentPaths[0]; const view = fragmentPaths[0];